Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

ff1b155731ff...
Will Cosgrove
Simplified _libssh2_check_length (#350)

* Simplified _libssh2_check_length

misc.c : _libssh2_check_length()

Removed cast and improved bounds checking and format.

Credit : Yuriy M. Kaminskiy
tiennou
GitHub Pull Request #369 (2 commits)
fb4cc5cb1f6d...
Daniel Stenberg
libssh2_session_supported_algs.3: fix formatting mistakes

Reported-by: Max Horn
Fixes #57
f6a8d1202ccc...
Will Cosgrove
Merge branch 'MichaelBuckley-michaelbuckley-security-fixes'
f5e84ae24163...
doublex
transport.c : fixes bounds check if partial packet is read

Files : transport.c

Issue : #360

Notes :
'p->total_num' instead of local value total_num when doing bounds check.

Credit : Doublex
e1ead35e4759...
Daniel Stenberg
libssh2_sftp.h: restore broken ABI

Commit 41fbd44 changed variable sizes/types in a public struct which
broke the ABI, which breaks applications!

This reverts that change.

Closes #339
dd74f2465b0c...
Tseng Jun
sftp.c : sftp_bin2attr() Correct attrs->gid assignment (#366)

Regression with fix for #339

Credit : Tseng Jun
dce4d8c7424a...
Will Cosgrove
Add agent functions libssh2_agent_get_identity_path() and libssh2_agent_set_identity_path() (#308)

File : agent.c

Notes :
Libssh2 uses the SSH_AUTH_SOCK env variable to read the system agent location. However, when using a custom agent path you have to set this value using setenv which is not thread-safe. The new functions allow for a way to set a custom agent socket path in a thread safe manor.
c9008ca66d25...
Will Cosgrove
Silence unused var warnings (#329)

Silence warnings about unused variables in this test
c3d89b9720a9...
Zenju
libssh2.h: Fix Error C2371 'ssize_t': redefinition

Closes #331
c07bc647f2b1...
Will Cosgrove
_libssh2_check_length() : additional bounds check (#348)

Misc.c : _libssh2_check_length()

Ensure the requested length is less than the total length before doing the additional bounds check
tiennou
GitHub Pull Request #369 (5 commits)
a19d85319dfc...
doublex
mbedtls.c : _libssh2_mbedtls_rsa_new_private_frommemory() allow private-key from memory (#359)

File : mbedtls.c

Notes: _libssh2_mbedtls_rsa_new_private_frommemory() fixes private-key from memory reading to by adding NULL terminator before parsing; adds passphrase support.

Credit: doublex
9ea7d3bcedda...
Zhen-Huan HWANG
sftp.c : discard and reset oversized packet in sftp_packet_read() (#269)

file : sftp.c

notes : when sftp_packet_read() encounters an sftp packet which exceeds SFTP max packet size it now resets the reading state so it can continue reading.

credit : Zhen-Huan HWANG
9d13d866273d...
Ryan Kelley
Session.c : banner_receive() from leaking when accessing non ssh ports (#356)

File : session.c

Release previous banner in banner_receive() if the session is reused after a failed connection.

Credit : Ryan Kelley
9ae4b9e949be...
Michael Buckley
Fix more scope and printf warning errors
934537c449ef...
Will Cosgrove
transport.c : scope local total_num var (#364)

file : transport.c
notes : move local `total_num` variable inside of if block to prevent scope access issues which caused #360.
8ab5c36a32ae...
Will Cosgrove
misc.c : String buffer API improvements (#332)

Files : misc.c, hostkey.c, kex.c, misc.h, openssl.c, sftp.c

Notes :
* updated _libssh2_get_bignum_bytes and _libssh2_get_string. Now pass in length as an argument instead of returning it to keep signedness correct. Now returns -1 for failure, 0 for success.

_libssh2_check_length now returns 0 on success and -1 on failure to match the other string_buf functions. Added comment to _libssh2_check_length.

Credit : Will Cosgrove
87fc75b23d4f...
Daniel Stenberg
session_disconnect: don't zero state, just clear the right bit

If we clear the entire field, the freeing of data in session_free() is
skipped. Instead just clear the bit that risk making the code get stuck
in the transport functions.

Regression from 4d66f6762ca3fc45d9.

Reported-by: dimmaq on github
Fixes #338
Closes #340
86e52ba63c1d...
Alexander Curtiss
libgcrypt.c : Fixed _libssh2_rsa_sha1_sign memory leak. (#370)

File: libgcrypt.c

Notes : Added calls to gcry_sexp_release to free memory allocated by gcry_sexp_find_token

Credit :
Reporter : beckmi
PR by: Alexander Curtiss
78fdc41c56ca...
Matthew D. Fuller
Spell OpenSS_H_ right when talking about their specific private key (#321)

Good catch, thanks.
76f1e8735b89...
Daniel Stenberg
src/checksrc.pl: code style checker

imported as-is from curl
6b46de8fd592...
Will Cosgrove
transport.c : fix for total_num bounds check

Fix for #360 from master.
4ac1ba718133...
Will Cosgrove
Silence unused var warnings (#329)

Silence warnings about unused variables in this test
460fe32f7dbb...
Tseng Jun
kex.c : Correct type cast in curve25519_sha256() (#365)
452517d96c2a...
Daniel Stenberg
style: make includes and examples code style strict

make travis and the makefile rule verify them too

Closes #334
4186a04cfded...
Daniel Stenberg
create a github issue template
3d7e0232d886...
Daniel Stenberg
stale-bot: activated

The stale bot will automatically mark stale issues (inactive for 90
days) and if still untouched after 21 more days, close them.

See https://probot.github.io/apps/stale/
38bf7ce9ece3...
Daniel Stenberg
misc: remove 'offset' from string_buf

It isn't necessary.

Closes #343
38818082c1e2...
Daniel Stenberg
sftp: repair mtime from e1ead35e475

A regression from e1ead35e4759 broke the SFTP mtime logic in
sftp_bin2attr

Also simplified the _libssh2_get_u32/u64 functions slightly.

Closes #342
2b45dfcad766...
Will Cosgrove
Formatting in agent.c

Removed whitespace.
1e2b63cbff88...
Will Cosgrove
Removed unneeded > 0 check

When checking `userauth_kybd_num_prompts > 100` we don't care if it's also above zero.
1cdbe63d0c0d...
Will Cosgrove
Editor config file for source files (#322)

Simple start to an editor config file when editing source files to make sure they are configured correctly.
1b3cbaff518f...
Daniel Stenberg
travis: add code style check

Closes #324
16f2d2bf863a...
Will Cosgrove
kex.c : additional bounds checks in diffie_hellman_sha1/256 (#361)

Files : kex.c, misc.c, misc.h

Notes :
Fixed possible out of bounds memory access when reading malformed data in diffie_hellman_sha1() and diffie_hellman_sha256().

Added _libssh2_copy_string() to misc.c to return an allocated and filled char buffer from a string_buf offset. Removed no longer needed s var in kmdhgGPshakex_state_t.
12bddb0d4592...
Daniel Stenberg
code style: unify code style

Indent-level: 4
Max columns: 79
No spaces after if/for/while
Unified brace positions
Unified white spaces
12343f11da8d...
Will Cosgrove
Fixed formatting in agent.c

Quiet linter around a couple if blocks and pointer.
1130615eeb60...
Orivej Desh
libssh2_priv.h : Fix musl build warning on sys/poll.h (#346)

File : libssh2_priv.h

Notes :
musl prints `redirecting incorrect #include <sys/poll.h> to <poll.h>`
http://git.musl-libc.org/cgit/musl/commit/include/sys/poll.h?id=54446d730cfb17c5f7bcf57f139458678f5066cc

poll is defined by POSIX to be in poll.h:
http://pubs.opengroup.org/onlinepubs/7908799/xsh/poll.html

Credit : Orivej Desh
088b376ccdc5...
Will Cosgrove
Removed unneeded > 0 check

When checking `userauth_kybd_num_prompts > 100` we don't care if it's also above zero.
01c67b2e4dc9...
Michael Buckley
Silence unused variable warning