Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

ffab6960b5f5...
Marc Hoersken
src: add new and align include guards in header files (#480)

Make sure all include guards exist and follow the same format.
ff9f228389ae...
Romain Geissler @ Amadeus
Session.c: Fix undefined warning when mixing with LTO-enabled libcurl. (#449)

File: Session.c

Notes:
With gcc 9, libssh2, libcurl and LTO enabled for all binaries I see this
warning (error with -Werror):

vssh/libssh2.c: In function ‘ssh_statemach_act’:
/data/mwrep/rgeissler/ospack/ssh2/BUILD/libssh2-libssh2-03c7c4a/src/session.c:579:9: error: ‘seconds_to_next’ is used uninitialized in this function [-Werror=uninitialized]
  579 |    int seconds_to_next;
      |        ^
lto1: all warnings being treated as errors

Gcc normally issues -Wuninitialized when it is sure there is a problem,
and -Wmaybe-uninitialized when it's not sure, but it's possible. Here
the compiler seems to have find a real case where this could happen. I
looked in your code and overall it seems you always check if the return
code is non null, not often that it's below zero. I think we should do
the same here. With this patch, gcc is fine.

Credit:
Romain-Geissler-1A
f1b6fca89b2c...
Daniel Stenberg
include/libssh2.h: fix comment: the known host key uses 4 bits (#438)
ee3abe04089c...
Tseng Jun
openssl.c: minor changes of coding style (#454)

File: openssl.c

Notes:
minor changes of coding style and align preprocessor conditional for #439

Credit:
Tseng Jun
e5dbd6f20cbe...
Michael Buckley
knownhost.c: Double the static buffer size when reading and writing known hosts (#409)

Notes:
We had a user who was being repeatedly prompted to accept a server key repeatedly. It turns out the base64-encoded key was larger than the static buffers allocated to read and write known hosts. I doubled the size of these buffers.

Credit:
Michael Buckley
e238df7353b5...
Will Cosgrove
os400qc3.h: define sha512 macros (#465)

file: os400qc3.h
notes: fixes for building libssh2 1.9.x
dedcbd106f8e...
Will Cosgrove
packet.c: improve message parsing (#402)

* packet.c: improve parsing of packets

file: packet.c

notes:
Use _libssh2_get_string API in SSH_MSG_DEBUG/SSH_MSG_DISCONNECT. Additional uint32 bounds check in SSH_MSG_GLOBAL_REQUEST.
bfcac7ccdac3...
Brendan Shanks
hostkey.c: Fix 'unsigned int'/'uint32_t' mismatch (#461)

File: hostkey.c

Notes:
These types are the same size so most compilers are fine with it, but CodeWarrior (on classic MacOS) throws an ‘illegal implicit conversion’ error

Credit: Brendan Shanks
ba149e804ef6...
Marc Hoersken
wincng: fix multiple definition of `_libssh2_wincng' (#479)

Add missing include guard and move global state
from header to source file by using extern.
b6773435138d...
Marc Hoersken
wincng: fix multiple definition of `_libssh2_wincng'

Add missing include guard and move global state
from header to source file by using extern.
b3b45813d61c...
Hans Meier
openssl.c: Fix for use of uninitialized aes_ctr_cipher.key_len (#453)

File:
Openssl.c

Notes:
* Fix for use of uninitialized aes_ctr_cipher.key_len when using HAVE_OPAQUE_STRUCTS, regression from #439

Credit:
Hans Meirer, Tseng Jun
96bbefb2ded9...
Will Cosgrove
.travis.yml: Fix Chrome and 32 bit builds (#423)

File: .travis.yml

Notes:
* Fix Chrome installing by using Travis build in directive
* Update to use libgcrypt20-dev package to fix 32 bit builds based on comments found here:
https://launchpad.net/ubuntu/xenial/i386/libgcrypt11-dev
92e5e01505a7...
Will Cosgrove
Update INSTALL_CMAKE filename to INSTALL_CMAKE.md (#445)

Fixing for #429
80d3ea5b413d...
Will Cosgrove
packet.c: improved packet parsing in packet_queue_listener (#404)

* improved bounds checking in packet_queue_listener

file: packet.c

notes:
improved parsing packet in packet_queue_listener
6e0f17f6728a...
monnerat
HACKING.CRYPTO: keep up to date with new crypto definitions from code. (#466)

File: HACKING.CRYPTO

Notes:
This commit updates the HACKING.CRYPTO documentation file in an attempt to make it in sync with current code.
New documented features are:

SHA384
SHA512
ECDSA
ED25519

Credit:
monnerat
651621cc69dd...
Marc Hoersken
src: add missing and align existing include guards in header files

Make sure all include guards exist and follow the same format.
642eec48ff3a...
lutianxiong
transport.c: fix use-of-uninitialized-value (#476)

file:transport.c

notes:
return error if malloc(0)

credit:
lutianxiong
508203da9bf3...
Hans Meier
openssl.c: Fix use-after-free crash in openssl backend without memory leak (#439)

Files: openssl.c

Notes:
Fixes memory leaks and use after free AES EVP_CIPHER contexts when using OpenSSL 1.0.x.

Credit:
Hans Meier
4e75a59e294b...
monnerat
os400qc3.c: constify libssh2_os400qc3_hash_update() data parameter. (#469)

Files: os400qc3.c, os400qc3.h

Notes:
Fixes building on OS400. #426

Credit:
Reported-by: hjindra on github, dev by Monnerat
suryakalpo
GitHub Pull Request #481 (1 commit)
387a666acfc0...
Marc Hoersken
WIP
35da19fe25c0...
Wallace Souza
Rename INSTALL_CMAKE to INTALL_CMAKE.md (#429)

Adding Markdown file extension in order to Github render the instructions properly
336bd86d2ca4...
Will Cosgrove
packet.c: improved parsing in packet_x11_open (#410)

Use new API to parse data in packet_x11_open() for better bounds checking.
katzer
GitHub Pull Request #385 (8 commits)
24fd419bde2c...
Zenju
ssh-ed25519: Support PKIX + calc pubkey from private (#416)

Files: openssl.c/h
Author: Zenju
Notes:
Adds support for PKIX key reading by fixing:

_libssh2_pub_priv_keyfile() is missing the code to extract the ed25519 public key from a given private key

_libssh2_ed25519_new_private_frommemory is only parsing the openssh key format but does not understand PKIX (as retrieved via PEM_read_bio_PrivateKey)
1e57d61b01fc...
Will Cosgrove
os400qc3.h: define EC types to fix building #426 (#462)

File: os400qc3.h
Notes: define missing EC types which prevents building
Credit: hjindra
1a082247a797...
Harry Sintonen
kex.c: Add diffie-hellman-group14-sha256 Key Exchange Method (#464)

File: kex.c

Notes: Added diffie-hellman-group14-sha256 kex

Credit: Harry Sintonen <sintonen@iki.fi>
159d4c813809...
Thomas Klausner
Makefile.am: Fix unportable test(1) operator. (#459)

file: Makefile.am

Notes:
The POSIX comparison operator for test(1) is =; bash supports == but not even test from GNU coreutils does.

Credit:
Thomas Klausner
14a7db0eaacf...
Will Cosgrove
Update INSTALL_MAKE path to INSTALL_MAKE.md (#446)

Included for #429
1105af5651b4...
Dr. Koutheir Attouchi
libssh2_sftp.h: Changed type of LIBSSH2_FX_* constants to unsigned long, fixes #474

File:
libssh2_sftp.h

Notes:
Error constants `LIBSSH2_FX_*` are only returned by `libssh2_sftp_last_error()` which returns `unsigned long`.
Therefore these constants should be defined as unsigned long literals, instead of int literals.

Credit:
Dr. Koutheir Attouchi
0effd5d41577...
Zenju
agent.c: Fix Unicode builds on Windows (#417)

File: agent.c

Notes:
Fixes unicode builds for Windows in Visual Studio 16.3.2.

Credit:
Zenju
0b44e558f311...
Will Cosgrove
transport.c: moving total_num check from #476 (#478)

file: transport.c

notes:
moving total_num zero length check from #476 up to the prior bounds check which already includes a total_num check. Makes it slightly more readable.

credit:
Will Cosgrove
07fc1532b622...
suryakalpo
INSTALL_CMAKE.md: Update formatting (#481)

File: INSTALL_CMAKE.md

Notes:
Although the original text would be immediately clear to seasoned users of CMAKE and/or Unix shell, the lack of newlines may cause some confusion for newcomers. Hence, wrapping the texts in a md code-block such that the newlines appear as intended.

credit:
suryakalpo
03c7c4a35171...
Zenju
transport.c: Fix crash with delayed compression (#443)

Files: transport.c

Notes:
Fixes crash with delayed compression option using Bitvise server.

Contributor:
Zenju